[EP] config rdma #619
Closed
[EP] config rdma #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into ep-efa-stability
[EP] EFA stability test
MaoZiming
reviewed
Jan 6, 2026
| // Add self-ranks, sub other ranks | ||
| if (thread_id < kNumRanks) { | ||
| atomicAdd_system(barrier_signal_ptrs[rank] + thread_id, FINISHED_SUM_TAG); | ||
| memory_fence(); |
Member
There was a problem hiding this comment.
Is the memory_fence() needed here?
Member
Author
There was a problem hiding this comment.
I followed rocm/deepep https://github.com/ROCm/DeepEP/blob/main/csrc/kernels/utils.cuh#L792
…ebug-amd-mem-consistency-yang
…ebug-amd-mem-consistency-yang
MaoZiming
reviewed
Jan 10, 2026
| perror("Failed to query device attributes"); | ||
| exit(1); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I tried this and
attr.max_dest_rd_atomic = dev_attr.max_qp_init_rd_atom;
It gets really slow on AMD platform.
MaoZiming
reviewed
Jan 10, 2026
| } | ||
| #if defined(__HIP_PLATFORM_AMD__) || defined(__HIPCC__) | ||
| memory_fence(); | ||
| #endif |
Member
There was a problem hiding this comment.
https://github.com/ROCm/DeepEP/blob/main/csrc/kernels/internode.cu#L906-L907
The ROCm one doesn't seem to have memory_fence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue.
Fixes # (issue)
Type of Change
How Has This Been Tested?
Include any tests here.
Checklist
format.sh.build_and_install.shto verify compilation.